[hal vulkan] Clean up Vulkan Validation Layer callback. - #9909
Open
jimblandy wants to merge 1 commit into
Open
Conversation
The wgpu-hal Vulkan backend, clean up the callback that reports VUID violations detected by the Vulkan Validation Layer: - Remove suppressions for VUIDs 01912, 04627, and 00184, as the upstream bugs responsible for these reports have been fixed for more than a year. - Fix some typos in comments.
ErichDonGubler
approved these changes
Jul 20, 2026
ErichDonGubler
left a comment
ErichDonGubler
left a comment
Member
There was a problem hiding this comment.
LGTM, minus CI being aang-y.
| if let Some(layer_properties) = user_data.validation_layer_properties.as_ref() { | ||
| if layer_properties.layer_description.as_ref() == c"Khronos Validation Layer" | ||
| && layer_properties.layer_spec_version >= vk::make_api_version(0, 1, 3, 240) | ||
| && layer_properties.layer_spec_version <= vk::make_api_version(0, 1, 3, 250) |
Member
There was a problem hiding this comment.
question: CI is failing on a warning now that these layer_properties members are never used. Worth keeping? Or shall we just toss it?
inner-daemons
approved these changes
Jul 27, 2026
inner-daemons
left a comment
inner-daemons
left a comment
Collaborator
There was a problem hiding this comment.
This is a wonderful and very welcome change IMO
Comment on lines
-29
to
-30
| const VUID_VKCMDENDDEBUGUTILSLABELEXT_COMMANDBUFFER_01912: i32 = 0x56146426; | ||
| if cd.message_id_number == VUID_VKCMDENDDEBUGUTILSLABELEXT_COMMANDBUFFER_01912 { |
Collaborator
There was a problem hiding this comment.
These names are killing me man, good riddance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wgpu-hal Vulkan backend, clean up the callback that reports VUID violations detected by the Vulkan Validation Layer:
Remove suppressions for VUIDs 01912, 04627, and 00184, as the upstream bugs responsible for these reports have been fixed for more than a year.
Fix some typos in comments.